Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

240202 - Update chevron size on all carousel buttons in skin/storybook #2261

Closed
6 tasks done
ratinsl opened this issue Feb 2, 2024 · 0 comments
Closed
6 tasks done
Assignees
Milestone

Comments

@ratinsl
Copy link

ratinsl commented Feb 2, 2024

Description

We have updated the chevron size/icon used across carousels and need them updated in Skin and Storybook.

We previously used 12px chevrons inside 32px buttons using icons:

  • chevron-left-12
  • chevron-right-12

We are now using 16px chevrons inside 32px buttons using icons:

  • chevron-left-16
  • chevron-right-16

Let me know if you have any questions,
Ryan

Screenshots

Chevron-size-update

Figma link

https://www.figma.com/file/zEBdEhbonrBOGzZ0fXzWvM/eBay-Design-System?type=design&node-id=69352-75639&mode=design&t=THPBQ5aqicoeOyys-4

Engineering pre-requisites

  • Successful design review with Design System Team.
  • Supports dark mode.
  • Supports responsive design.
  • Tokens have been provided (or already exist).
  • Successful accessibility review with Core A11Y Team.
  • Successful frontend review with eBayUI Team.
@agliga agliga added this to eBayUI Feb 5, 2024
@agliga agliga added this to the 17.3.0 milestone Feb 15, 2024
@agliga agliga removed this from eBayUI Feb 15, 2024
@agliga agliga added this to eBayUI Feb 15, 2024
@agliga agliga moved this to Todo in eBayUI Feb 21, 2024
@ArtBlue ArtBlue moved this from Todo to In Progress in eBayUI Mar 4, 2024
@ArtBlue ArtBlue moved this from In Progress to Pull request in eBayUI Mar 5, 2024
@ArtBlue ArtBlue moved this from Pull request to Done in eBayUI Mar 8, 2024
@ArtBlue ArtBlue closed this as completed Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants