Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

240327 - Skeleton fill/shimmer token updates #2305

Closed
6 tasks done
ratinsl opened this issue Mar 28, 2024 · 0 comments
Closed
6 tasks done

240327 - Skeleton fill/shimmer token updates #2305

ratinsl opened this issue Mar 28, 2024 · 0 comments
Assignees
Milestone

Comments

@ratinsl
Copy link

ratinsl commented Mar 28, 2024

Description

Problem

The skeleton loader becomes difficult to see on surfaces using background.secondary. Additionally, the skeleton loader on background.primary can also use more contrast.

Solution

Create a set of on-secondary colors for the skeleton pattern to remain visible on surfaces using background.secondary. This is meant to replace any "elevated" tokens that were previously used for skeletons.

Update on-primary colors for the skeleton pattern to be better visible on surfaces using background.primary.

Success criteria

A color.loading.fill.onSecondary and a color.loading.shimmer.onSecondary token are added to the library and made available for the skeleton loader to consume. Additionally color.loading.fill and color.loading.shimmer are updated to match new color specs.

Resources

Figma loading token table update

Updated Figma skeleton documentation

Screenshots

image

Figma link

No response

Engineering pre-requisites

  • Successful design review with Design System Team.
  • Supports dark mode.
  • Supports responsive design.
  • Tokens have been provided (or already exist).
  • Successful accessibility review with Core A11Y Team.
  • Successful frontend review with eBayUI Team.
@agliga agliga added this to eBayUI Apr 4, 2024
@agliga agliga added this to the 17.4.0 milestone Apr 4, 2024
@agliga agliga moved this to In Progress in eBayUI Apr 4, 2024
@agliga agliga self-assigned this Apr 4, 2024
@agliga agliga moved this from In Progress to Pull request in eBayUI Apr 8, 2024
@agliga agliga moved this from Pull request to Done in eBayUI Apr 16, 2024
@agliga agliga closed this as completed Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants