Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(tokens): Show semantic tokens before primitive #2383

Closed
6 tasks
LuLaValva opened this issue Jul 15, 2024 · 0 comments
Closed
6 tasks

docs(tokens): Show semantic tokens before primitive #2383

LuLaValva opened this issue Jul 15, 2024 · 0 comments
Assignees
@saiponnada
Labels
type: documenation
Milestone
18.3.0

Comments

@LuLaValva
Copy link
Member

Description

We should show semantic tokens first since they are recommended, and primitive tokens should be surrounded by a disclaimer that they should not be used unless absolutely needed. It may also be nice to hide primitive tokens behind a <details> menu.

Screenshots

No response

Figma link

No response

Engineering pre-requisites

  • Successful design review with Design System Team.
  • Supports dark mode.
  • Supports responsive design.
  • Tokens have been provided (or already exist).
  • Successful accessibility review with Core A11Y Team.
  • Successful frontend review with eBayUI Team.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saiponnada saiponnada

Labels
type: documenation
Projects
eBayUI
Status: Done
Milestone
18.3.0
Development

No branches or pull requests
3 participants
@agliga @saiponnada @LuLaValva