Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added auto published when merge to master #2264

Merged
merged 2 commits into from
Feb 14, 2024
Merged

feat: added auto published when merge to master #2264

merged 2 commits into from
Feb 14, 2024

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Feb 7, 2024

Fixes #1996

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  • Added github actions config to auto publish

@agliga agliga self-assigned this Feb 7, 2024
@agliga agliga marked this pull request as ready for review February 9, 2024 00:40
Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! The code looks good. Is there a dry-run option so we can test it or would the testing be done live later with an actual release?

@agliga
Copy link
Contributor Author

agliga commented Feb 9, 2024

This is awesome! The code looks good. Is there a dry-run option so we can test it or would the testing be done live later with an actual release?

Unfortunately, I'm going to have to merge to master and then test it out there
I think I'm gonna test it with some patches for now (maybe some docs change or some thing along those lines) and then verify that it's being published automatically
Once we get it working, then we'll do the real release with it.

LuLaValva
LuLaValva previously approved these changes Feb 12, 2024
Copy link

changeset-bot bot commented Feb 14, 2024

🦋 Changeset detected

Latest commit: 3ef20db

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@agliga agliga merged commit 32e58f3 into master Feb 14, 2024
@agliga agliga deleted the auto-publish branch February 14, 2024 19:14
@github-actions github-actions bot mentioned this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: automatically publish skin
3 participants