Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toggle-button-group): fixed Safari image size bug and added stories #2282

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

ArtBlue
Copy link
Contributor

@ArtBlue ArtBlue commented Mar 4, 2024

Fixes #2241

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

Fixed a Safari bug in toggle-button-group that was causing images to ignore its container constraints.

Notes

  • I added stories for use cases.
  • I did not run visual regression because we did not have any stories for the error case.

Screenshots

Before

toggle-button-group-Safari-issue


After

toggle-button-group-Safari-fixed

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

Copy link

changeset-bot bot commented Mar 4, 2024

🦋 Changeset detected

Latest commit: 26c5ed5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ArtBlue ArtBlue merged commit 5df6ffc into 17.3.0 Mar 11, 2024
@ArtBlue ArtBlue deleted the 2241-ebay-toggle-button-image-bug branch March 11, 2024 19:03
@github-actions github-actions bot mentioned this pull request Mar 11, 2024
@github-actions github-actions bot mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants