Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(education-notice): new module #2286

Merged
merged 4 commits into from
Mar 13, 2024
Merged

Conversation

ArtBlue
Copy link
Contributor

@ArtBlue ArtBlue commented Mar 8, 2024

Fixes #2271

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

Created a new education-notice module.

Notes

I added a note to the section-notice education variation section indicating the variation will be deprecated and start using this module instead.

Screenshots

image image image

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

Copy link

changeset-bot bot commented Mar 8, 2024

🦋 Changeset detected

Latest commit: cae3b6f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Arthur!

Copy link
Contributor

@saiponnada saiponnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm, just some comments

docs/_includes/section-notice.html Outdated Show resolved Hide resolved
@ArtBlue ArtBlue merged commit 9861294 into 17.3.0 Mar 13, 2024
1 check passed
@ArtBlue ArtBlue deleted the 2271-education-notice-update branch March 13, 2024 20:31
@github-actions github-actions bot mentioned this pull request Mar 13, 2024
@github-actions github-actions bot mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants