refactor(progress-bar-expressive): rename expressive-loader to progress-bar-expressive #2290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… progress-bar-expressive
🦋 Changeset detectedLatest commit: 70515f3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
cordeliadillon
commented
Mar 13, 2024
| @@ -0,0 +1,277 @@ | |||
| :root { | |||
There was a problem hiding this comment.
Only changes in this file are expressive-loader --> progress-bar-expressive
cordeliadillon
commented
Mar 13, 2024
| @@ -0,0 +1,117 @@ | |||
| export default { title: "Skin/Progress Bar Expressive" }; | |||
There was a problem hiding this comment.
Changed storybook name and CSS classes.
ianmcburnie
approved these changes
Mar 13, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2289
Description
Rename
expressive-loadermodule toprogress-bar-expressivemodule for more semantic naming and consistency with other progress modules. Update CSS class names, CSS variables, helper JS, and docs accordingly.Checklist