Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(education-notice): use icon button #2294

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

ArtBlue
Copy link
Contributor

@ArtBlue ArtBlue commented Mar 18, 2024

Fixes #2293

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

Changed the button to an icon button matching the smallest size we have to what the Figma contains.

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

Copy link

changeset-bot bot commented Mar 18, 2024

🦋 Changeset detected

Latest commit: cc34b1c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just one comment about transparent icon button.

dist/education-notice/education-notice.css Show resolved Hide resolved
@ArtBlue ArtBlue merged commit 16d681b into 17.3.0 Mar 19, 2024
1 check passed
@ArtBlue ArtBlue deleted the 2293-education-notice-use-icon-button branch March 19, 2024 13:15
This was referenced Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants