Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(skeletons): added on-secondary color #2306

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Apr 8, 2024

Fixes #2305

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  • Added skeleton--on-secondary modifier
  • Updated tokens for both base skeleton colors but also for on-secondary
  • As per design --elevated is deprecated. The colors in on-secondary should be used in --elevated

Screenshots

Screenshot 2024-04-08 at 11 52 01 AM Screenshot 2024-04-08 at 11 53 48 AM

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@agliga agliga self-assigned this Apr 8, 2024
Copy link

changeset-bot bot commented Apr 8, 2024

🦋 Changeset detected

Latest commit: 18a46ff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@agliga
Copy link
Contributor Author

agliga commented Apr 8, 2024

Question, should we call this on-secondary or change it to simply secondary?

Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agliga agliga merged commit 8cdc782 into 17.4.0 Apr 10, 2024
2 checks passed
@agliga agliga deleted the skeleton-on-secondary-colors branch April 10, 2024 17:36
@github-actions github-actions bot mentioned this pull request Apr 16, 2024
@github-actions github-actions bot mentioned this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants