docs(progress-bar-expressive): fix noisy status updates on docs page #2312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0dc0357 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ianmcburnie
approved these changes
Apr 15, 2024
saiponnada
approved these changes
Apr 15, 2024
agliga
requested changes
Apr 15, 2024
cordeliadillon
force-pushed
the
2311-status
branch
from
99b2685
to
f313a32
Compare
Great suggestion, @saiponnada! I updated the docs and re-requested your review. :) |
agliga
approved these changes
Apr 15, 2024
cordeliadillon
force-pushed
the
2311-status
branch
from
f313a32
to
0dc0357
Compare
|
@saiponnada @agliga, thanks for the re-review! Feel free to merge when ready. (I don't have merge access.) |
1 task
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2311
Description
The message elements with
role="status"in the expressive progress bar doc examples are reading out constantly when perusing the Skin docs with a screen reader. This update setsaria-live="off"on the rendered examples (but not on the rendered code snippets) so as not to be so disruptive when someone is reading the Skin docs.Notes
I opted to use
aria-live="off"rather than removingrole="status", since we use the status role as a selector in themain.jsfile. Setting an explicitaria-live="off"overrides status's implicitaria-live="polite".Screenshots
N/A
Checklist