Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icon-button): fixed primary visited link icon color #2322

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

ArtBlue
Copy link
Contributor

@ArtBlue ArtBlue commented Apr 29, 2024

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

Fixing issue discovered post-release. Icon buttons that use link need to have the same color icons as the ones using non-visited links.

Screenshots

Before

image

After

image

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

Copy link

changeset-bot bot commented Apr 29, 2024

🦋 Changeset detected

Latest commit: a8c2dc2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot mentioned this pull request Apr 29, 2024
@ArtBlue ArtBlue self-assigned this Apr 29, 2024
@ArtBlue ArtBlue merged commit 292c8eb into master Apr 29, 2024
3 checks passed
@ArtBlue ArtBlue deleted the 17.4.0-fix-icon-button branch April 29, 2024 20:32
@github-actions github-actions bot mentioned this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants