Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toggle-button): added hover and pressed states #2332

Merged
merged 2 commits into from
May 10, 2024

Conversation

ArtBlue
Copy link
Contributor

@ArtBlue ArtBlue commented May 9, 2024

Fixes #2315

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

Added hover and pressed states. Per DS, the state tokens needed to be revised as well (includede).

Notes

Since hovers exposed the rgba transparency color and made buttons look yellow, I also removed the yellow background color from the toggle-button-group docs to avoid relaying misinformation to devs about its potential usage inside any container with any other background color.

Screenshots

Before

Hover

image

Pressed

image

After

Hover
image

Pressed(active)

image

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@ArtBlue ArtBlue self-assigned this May 9, 2024
Copy link

changeset-bot bot commented May 9, 2024

🦋 Changeset detected

Latest commit: a28c241

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ArtBlue ArtBlue merged commit 186bd9a into 17.5.0 May 10, 2024
1 check passed
@ArtBlue ArtBlue deleted the 2315-toggle-button-add-states branch May 10, 2024 16:19
@github-actions github-actions bot mentioned this pull request May 10, 2024
@github-actions github-actions bot mentioned this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants