feat: added sass support and removed less support #2348
Conversation
🦋 Changeset detectedLatest commit: 6765dec The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| --dialog-lightbox-max-width: 616px; | ||
| --dialog-scrim-color-hide: #11182000; | ||
| --dialog-scrim-color-show: #111820b3; | ||
| --dialog-lightbox-max-width: 616px; |
There was a problem hiding this comment.
Was the change in indentation intentional? Unless there was an oversight previously, it would be best to keep the same indentation.
There was a problem hiding this comment.
I believe prettier was not run on the app. I simply ran prettier which changed the indent.
There was a problem hiding this comment.
Okay, for more context
Dist was in the prettier ignore list. I believe this was due to it changing the format and this might have been picked up on npm run build
I changed it so npm run build runs prettier on dist folder. This is to keep the same formatting across the app.
Creating a draft initially. Still have some minor things to work through
Questions to be answered
If the first pass looks good, I will go ahead and rework the paths and do other cleanups, like remove gulpfile, dev deps no longer used etc.