-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(textbox): fixed large textbox height #2392
Conversation
🦋 Changeset detectedLatest commit: 058d05f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just double check across all tier 1 browsers if not done so already.
src/sass/textbox/textbox.scss
Outdated
.textbox--large > input.textbox__control { | ||
height: 48px; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also a problem for .textbox
(without --large
). I like moving the size up to the parent container, but if you are doing that you should also change the child.
These are the changes I think we need:
.textbox { height: 40px }
.textbox__control { height: 100% }
- Remove this selector and its contents (
.textbox--large > input.textbox__control
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LuLaValva , I reworked this based on our discussion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the back-and-forth, looks good now!
Fixes #2389
Description
Fixes large textbox height.
Screenshots
Before
After
Checklist