Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(education-notice): updated education background color #2415

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

saiponnada
Copy link
Contributor

Fixes #2370

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

Updated tokens to reflect new DS colors for education notice

Notes

  • Pending Percy testing

Screenshots

image image

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

Copy link

changeset-bot bot commented Aug 8, 2024

🦋 Changeset detected

Latest commit: 2741132

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but let's wait until we merge in the Skin marko run restructuring. After that's merged the changes will need to be made in the appropriate files as the structure is likely changing.

@saiponnada saiponnada merged commit 9d24641 into 18.2.0 Aug 14, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Aug 14, 2024
@github-actions github-actions bot mentioned this pull request Aug 29, 2024
@saiponnada saiponnada deleted the education-color branch September 10, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants