Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lightbox): add divider over footer #2441

Merged
merged 1 commit into from
Sep 20, 2024
Merged

feat(lightbox): add divider over footer #2441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/healthy-eyes-trade.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ebay/skin": minor
---

feat(lightbox): add divider over footer
3 changes: 2 additions & 1 deletion dist/lightbox-dialog/lightbox-dialog.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@
}

.lightbox-dialog__footer {
border-top: 1px solid
var(--dialog-lightbox-separator-color, var(--color-stroke-subtle));
display: flex;
flex-direction: column;
justify-content: center;
Expand Down Expand Up @@ -283,7 +285,6 @@ button.icon-btn.lightbox-dialog__prev {
.lightbox-dialog__window .lightbox-dialog__footer {
flex-direction: row;
justify-content: flex-end;
padding: 0 var(--spacing-200) var(--spacing-200);
saiponnada marked this conversation as resolved.
Show resolved Hide resolved
}
.lightbox-dialog__window .lightbox-dialog__footer > :not(:first-child) {
margin-left: var(--spacing-100);
Expand Down
3 changes: 3 additions & 0 deletions src/sass/lightbox-dialog/lightbox-dialog.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@

.lightbox-dialog__footer {
@include dialog-footer-content();

border-top: 1px solid
var(--dialog-lightbox-separator-color, var(--color-stroke-subtle));
}

.lightbox-dialog__image {
Expand Down
1 change: 0 additions & 1 deletion src/sass/mixins/private/_dialog-mixins.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@
@mixin dialog-footer-content-large() {
flex-direction: row;
justify-content: flex-end;
padding: 0 var(--spacing-200) var(--spacing-200);

& > :not(:first-child) {
margin-left: var(--spacing-100);
Expand Down