Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tokens): add primitive token disclaimer #2442

Merged
merged 1 commit into from
Sep 13, 2024
Merged

docs(tokens): add primitive token disclaimer #2442

merged 1 commit into from
Sep 13, 2024

Conversation

saiponnada
Copy link
Contributor

Fixes #2383

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  • Updated docs with disclaimer to refrain using primitive tokens.
  • Moved semantic tokens above the primitive tokens.
  • Also wrapped the primitive tokens inside a details element.

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

Copy link

changeset-bot bot commented Sep 11, 2024

🦋 Changeset detected

Latest commit: 220d7fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love the formatting (space before tag params, no indentation in the body of the nested for loop) but those aren't new changes from this PR so I'll approve.

@saiponnada saiponnada merged commit d330c82 into 18.3.0 Sep 13, 2024
@github-actions github-actions bot mentioned this pull request Sep 13, 2024
@github-actions github-actions bot mentioned this pull request Sep 27, 2024
@agliga agliga deleted the token-docs branch September 28, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants