Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(table): added thead line for scrolling, reverted table contraint #2473

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

ArtBlue
Copy link
Contributor

@ArtBlue ArtBlue commented Oct 24, 2024

Fixes #2457

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  • Allowed the line under <thead> to make the UI look better when scrolling.
  • Reversed the way we're handling table height constraint.

Screenshots

image

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@ArtBlue ArtBlue self-assigned this Oct 24, 2024
Copy link

changeset-bot bot commented Oct 24, 2024

🦋 Changeset detected

Latest commit: bb4345e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agliga agliga merged commit 94f4201 into 18.4.0 Oct 25, 2024
@agliga agliga deleted the table-3-adjustments branch October 25, 2024 16:25
This was referenced Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants