Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(list): added interactive radio fieldet and incremental list #2481

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Nov 1, 2024

Fixes #2477

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  • Added fieldset support
  • Added ol support as well as automatic numbering

Question for the fieldest, I added a legend. Should we hide it? I left it in but styled it as a list item. We can clip it if needed since it wasn't in the original design.

Screenshots

Screenshot 2024-11-01 at 10 20 58 AM Screenshot 2024-11-01 at 10 21 03 AM

Checklist

  • I verify the build is in a non-broken state

  • I verify all changes are within scope of the linked issue

  • I regenerated all CSS files under dist folder

  • I tested the UI in all supported browsers

  • I did a visual regression check of the components impacted by doing a Percy build and approved the build

  • I tested the UI in dark mode and RTL mode

  • I added/updated/removed Storybook coverage as appropriate

src/sass/list/list.scss Outdated Show resolved Hide resolved
Copy link

changeset-bot bot commented Nov 1, 2024

🦋 Changeset detected

Latest commit: 2b70fcc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a couple of things.

src/modules/list.marko Show resolved Hide resolved
src/modules/list.marko Show resolved Hide resolved
@agliga
Copy link
Contributor Author

agliga commented Nov 15, 2024

Going to merge, if there are any more issues we will address them in follow up (so this does not get stale)

@agliga agliga merged commit 933fb74 into 18.5.0 Nov 15, 2024
@agliga agliga deleted the list-v2 branch November 15, 2024 20:28
@github-actions github-actions bot mentioned this pull request Nov 14, 2024
@github-actions github-actions bot mentioned this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants