Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filter-menu): added search header #2496

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Conversation

ArtBlue
Copy link
Contributor

@ArtBlue ArtBlue commented Nov 13, 2024

Fixes #2451

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

Added search header for filter menu

Notes

I fixed a minor spacing issue for filter menu items for RTL.

Screenshots

image

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

Copy link

changeset-bot bot commented Nov 13, 2024

🦋 Changeset detected

Latest commit: c13c516

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@agliga agliga merged commit 66e73f8 into 18.5.0 Nov 14, 2024
@github-actions github-actions bot mentioned this pull request Nov 14, 2024
@github-actions github-actions bot mentioned this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants