Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #197 in preparation for 5.1.0 Release #201

Merged
merged 133 commits into from
Nov 18, 2017
Merged

Closes #197 in preparation for 5.1.0 Release #201

merged 133 commits into from
Nov 18, 2017

Conversation

deaktator
Copy link
Contributor

Summary

Merge development into master for 5.1.0 Release.

Resolves

Code Reviewer(s)

@jmorra

deaktator and others added 30 commits August 30, 2017 12:32
@deaktator
initial commit with some ideas on how to do multilabel.
773b3b1
@deaktator
Additional hacking on multilabel model.
66817f7
@deaktator
Added multilabel type aliases. Updated MultilabelModel but it's broken.
c2516f5
@deaktator
Added additional commentst.
73d378b
@deaktator
Made SparseLabelDepFeatures type alias a little nicer but abused nota…
48a6157 
…tion a little.
@deaktator
New plan. No label-dependent features for now.
0ebc108
@deaktator
moved MultilabelModel to multilabel package.
8ba3e6e
@deaktator
updated comments
5931ef0
@deaktator
Removed the requirements that SparseMultiLabelPredictor is Closeable.
5e1f1dc
@deaktator
Added comment to predictor.
0aea10c
@deaktator
Updated skeleton of MultilabelModel and small change to RegressionFea…
85229f9 
…tures.
@deaktator
Added B <: U in helper methods.
7812019
@deaktator
Added a few comments to model and added test skeleton.
f78e4bd
@deaktator
removed parameters to Auditor. Just use defaults because the values d…
f21fa4f 
…on't matter because there are no sub models or super models.
@deaktator
Added import to companion object Label type and Auditor.
a9a0f8b
@deaktator
Added additional test.
2d6de6f
@deaktator
SparseMultiLabelPredictor was made package private for testing.
6defbe0
@deaktator
updated privacy of type aliases in multilabel package object
7661df2
@amirziai
Serialization test
9fd15ad
@amirziai
First test passing
ce66b7c
@deaktator
Hopefully code complete for the case class.
75dee22
@amirziai
Merge branch '163-multilabel' into 163-multilabel-test
599e336
@deaktator
Added comment.
2e0f4eb
@amirziai
Merge branch '163-multilabel' into 163-multilabel-test
3dc2921
@deaktator
lessened privileges.
3b2652b
@amirziai
Merge remote-tracking branch 'upstream/163-multilabel' into 163-multi…
dd7dc71 
…label-test
@amirziai
Adding more multi-label tests
999348b
@amirziai
Success report test case
a38b5ea
@deaktator
Addressing JMorra's PR comments.
a5c5259
@amirziai
More tests
2657672
deaktator and others added 28 commits October 9, 2017 14:39
@deaktator
added different padding.
6f89630
@deaktator
Updated documentation and tests. Looks good.
95e0c92
@deaktator
Updated VW label NS algo. Added test for when a NS can't be found.
a7b168a
@deaktator
hacky solution to flags with options referencing files. Use tmp files…
9c4362b 
… :-(
@deaktator
Looks good.
6df3f83
@deaktator
Precompute positive and negative dummy class strings.
cd50006
@deaktator
Adding numUniqueLabels parameter to updatedVwParams to add VW's --rin…
ffd10ee 
…g_size parameter
@deaktator
stateful row creator and reservoir sampling.
9592b09
@deaktator
provided concrete implementations of iterator and vector apply method.
8e478f3
@deaktator
more purity in test.
b7594fa
@deaktator
separated pure and impure code.
819095a
@deaktator
no more. good enough.
b190821
@deaktator
It's never good enough, even on a football Saturday.
5e1ebd0
@deaktator
Seq -> List
0889971
@deaktator
VwDownsampledMultilabelRowCreator and supporting infrastructure and t…
d60f226 
…ests.
@deaktator
Made Rand use Int indices, made k < 2^15 in neg label sampling. Updat…
fe8dca2 
…ed StatefulRowCreator API.
@deaktator
Addressing PR comments. Removed VW params from VW multi-label model c…
baf7466 
…ode.
@deaktator
Downsampling can now operate over 2^31 - 1 (2 billion) labels.
22d9547
@deaktator
changed Iterator.isEmpty to hasNext. Updated docs.
c463c11
@deaktator
forgot logical not in if statement.
79fddb6
@deaktator
removed toShort from Rand.
1c0102c
@deaktator
addressing PR comments. Changed name of multilabel model to 'SparseMu…
6e21f8c 
…ltilabel'. Generalized StatefulRowCreator.
@deaktator
Merge pull request #193 from eHarmony/163-multilabel
c4c5502 
Closes #163
@deaktator
5.0.1-SNAPSHOT -> 5.1.0-SNAPSHOT
d22e919
@deaktator
Merge pull request #195 from eHarmony/194-aloha-5.1.0-SNAPSHOT
ef8c180 
5.0.1-SNAPSHOT -> 5.1.0-SNAPSHOT
removed SCM section from pom content because new sbt-git version pull…
f8588f3 
…ed in from microsites plugin automatically adds it. Leaving it in breaks deploy. See sbt/sbt-git#117 for details.
@deaktator
Merge pull request #199 from eHarmony/197-double-scm
c32bcca 
Closes #197
@deaktator
Merge branch 'master' into development
a27a0cd
@deaktator deaktator merged commit 1209b47 into master Nov 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmorra jmorra jmorra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deaktator @jmorra @amirziai