Refs #20306: Apply Miguel's suggestions

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
eProsima · Jan 24, 2024 · b336b07 · b336b07
1 parent 99723c2
commit b336b07
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/cpp/rtps/builtin/data/ParticipantProxyData.cpp b/src/cpp/rtps/builtin/data/ParticipantProxyData.cpp
@@ -469,6 +469,7 @@ bool ParticipantProxyData::readFromCDRMessage(
                         // TODO(eduponz): This is a workaround for the moment, as it is implicitly assuming
                         // that the vendor ID parameter came before this one. In the future, we should propagate
                         // the vendor ID from the RTPS message header using the CacheChange and check it here.
+                        FASTDDS_TODO_BEFORE(2, 14, "Add vendor ID to CacheChange");
                         if (c_VendorId_eProsima != m_VendorId)
                         {
                             return true;

diff --git a/test/unittest/rtps/builtin/BuiltinDataSerializationTests.cpp b/test/unittest/rtps/builtin/BuiltinDataSerializationTests.cpp
@@ -445,7 +445,7 @@ TEST(BuiltinDataSerializationTests, other_vendor_parameter_list_with_custom_pids
 
         // PID_PARTICIPANT_GUID
         0x50, 0, 16, 0,
-        1, 16, 54, 83, 136, 247, 149, 252, 47, 105, 174, 141, 0, 0, 1, 193,
+        2, 0, 54, 83, 136, 247, 149, 252, 47, 105, 174, 141, 0, 0, 1, 193,
 
         // PID_NETWORK_CONFIGURATION_SET
         0x07, 0x80, 8, 0,