Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dds crashes when writing #2701

Closed
1 task done
huqin-RM opened this issue May 26, 2022 · 1 comment
Closed
1 task done

dds crashes when writing #2701

huqin-RM opened this issue May 26, 2022 · 1 comment
Labels
triage Issue pending classification

Comments

@huqin-RM
Copy link

Is there an already existing issue for this?

  • I have searched the existing issues

Expected behavior

I wrote 20m data

Current behavior

I wrote 20m data,but crashed

Steps to reproduce

void TopicPayloadPool::reserve (
uint32_t min_num_payloads,
uint32_t size)
{
assert (min_num_payloads <= max_pool_size_);

for (size_t i = all_payloads_.size(); i < min_num_payloads; ++i)
{
    PayloadNode* payload = do_allocate(size);
    free_payloads_.push_back(payload);
}

}

Does not judge whether the payload is nullptr。Will it crash when writing data?

Fast DDS version/commit

2.6

Platform/Architecture

Windows 10 Visual Studio 2019

Transport layer

UDPv4

Additional context

No response

XML configuration file

No response

Relevant log output

No response

Network traffic capture

No response

@huqin-RM huqin-RM added the triage Issue pending classification label May 26, 2022
@Mario-DL
Copy link
Member

Mario-DL commented Dec 1, 2022

Hi @huqin-RM,

Sorry for the late response and thanks for the report. The proposed nullptr check was added in #2976 and included in the 2.8.1 release, so I am closing this issue.

@Mario-DL Mario-DL closed this as completed Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Issue pending classification
Projects
None yet
Development

No branches or pull requests

2 participants