Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20658] TopicPayloadPool memory leak problem #4553

Closed
1 task done
fujitatomoya opened this issue Mar 13, 2024 · 7 comments · Fixed by #4673
Closed
1 task done

[20658] TopicPayloadPool memory leak problem #4553

fujitatomoya opened this issue Mar 13, 2024 · 7 comments · Fixed by #4673
Labels
in progress Issue or PR which is being reviewed

Comments

@fujitatomoya
Copy link
Contributor

Is there an already existing issue for this?

  • I have searched the existing issues

Expected behavior

TopicPayloadPool::all_payloads_ should not memory leak, instead it should be able to release the heap memory accordingly.

Current behavior

TopicPayloadPool::all_payloads_ memory usage rises, and never be reduced.

Steps to reproduce

  1. Enable Security with -DSECURITY=ON.
  2. based on SecureHelloWorldExample, create 2 subscriptions with different partition like below.

image

  1. create one publisher that switches partition to subscriber A and B after matching.
  2. on each matching, memory leak happens on publisher and subscriptions.

Fast DDS version/commit

Originally found on v2.10.1.

Platform/Architecture

Ubuntu Focal 20.04 arm64

Transport layer

UDPv4

Additional context

image

XML configuration file

No response

Relevant log output

No response

Network traffic capture

No response

@fujitatomoya fujitatomoya added the triage Issue pending classification label Mar 13, 2024
@fujitatomoya
Copy link
Contributor Author

@MiguelCompany @EduPonz this looks like a memory leak bug pretty much... do you happen to know the existed issue?

@fujitatomoya
Copy link
Contributor Author

CC: @Barry-Xu-2018

@JesusPoderoso
Copy link
Contributor

Hi @fujitatomoya, thanks for the report.
We will address it in the next few days.
Do you know if it also happens with security disabled? Regarding changing partitions, have you tried without changing partitions?
It would be lovely if you can also provide a minimal reproducer.
Thanks again!

@fujitatomoya
Copy link
Contributor Author

Do you know if it also happens with security disabled?

No this problem does not happen without security.

Regarding changing partitions, have you tried without changing partitions?

This problem (increasing memory usage) happens only when switching the partition.

@MiguelCompany MiguelCompany added need more info Issue that requires more info from contributor and removed triage Issue pending classification labels Mar 15, 2024
@MiguelCompany
Copy link
Member

@fujitatomoya Could you provide details on the configuration?

We would need the QoS configuration of the publisher and the subscribers, and also the security configuration (the protection kinds in particular)

@MiguelCompany MiguelCompany changed the title TopicPayloadPool memory leak problem [20658] TopicPayloadPool memory leak problem Apr 9, 2024
@MiguelCompany
Copy link
Member

@fujitatomoya We finally found the issue. See #4673 for a fix

@fujitatomoya
Copy link
Contributor Author

@MiguelCompany thanks! appreciate that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress Issue or PR which is being reviewed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants