[19089] Fix HelloWorld DataSharing example idl #3714

JesusPoderoso · 2023-07-13T13:58:40Z

Description

One of the Data-sharing constraints is that the types must be bounded. In the Data-sharing helloworld example, it is forced to use datasharing but the IDL types do not use bounded strings.
This Pull Request updates IDL to use bounded string, and regenerates the types with the bounded string.

@Mergifyio backport 2.11.x 2.10.x 2.6.x

Fixes #3710

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Changes are ABI compatible.
N/A Changes are API compatible.
N/A New feature has been added to the versions.md file (if applicable).
N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

Mario-DL · 2023-09-20T07:44:14Z

Changes LGTM. I was wondering if the changes should be backported, in that case, the types should be re-generated with the corresponding fastddsgen version, what do you think @EduPonz ?. Also, if backporting is considered, it should be 2.11.x, 2.10.x and 2.6.x

JLBuenoLopez · 2023-09-20T07:49:48Z

Changes LGTM. I was wondering if the changes should be backported, in that case, the types should be re-generated with the corresponding fastddsgen version, what do you think @EduPonz ?. Also, if backporting is considered, it should be 2.11.x, 2.10.x and 2.6.x

I think this should be backported and the types should be regenerated as suggested by Mario.

JesusPoderoso · 2023-09-20T08:15:27Z

@Mergifyio backport 2.11.x 2.10.x 2.6.x

mergify · 2023-09-20T08:15:45Z

backport 2.11.x 2.10.x 2.6.x

✅ Backports have been created

#3884 [19089] Fix HelloWorld DataSharing example idl (backport #3714) has been created for branch 2.11.x but encountered conflicts
#3885 [19089] Fix HelloWorld DataSharing example idl (backport #3714) has been created for branch 2.10.x but encountered conflicts
#3886 [19089] Fix HelloWorld DataSharing example idl (backport #3714) has been created for branch 2.6.x but encountered conflicts

Mario-DL · 2023-09-20T11:59:15Z

@richiprosima please test this

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

JesusPoderoso · 2023-09-27T10:50:28Z

@richiprosima please test this

Mario-DL · 2023-09-27T11:04:47Z

@richiprosima please test this

JesusPoderoso · 2023-09-27T12:02:51Z

@richiprosima please test this

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

Mario-DL

LGTM with Green Windows v141 ci

* Refs #19089: Fix HelloWorld DataSharing example idl as bounded Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19089: Revert uncrustify fix in types Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> (cherry picked from commit 4fed0bd) # Conflicts: # examples/cpp/dds/HelloWorldExampleDataSharing/HelloWorld.h # examples/cpp/dds/HelloWorldExampleDataSharing/HelloWorldCdrAux.hpp

* Refs #19089: Fix HelloWorld DataSharing example idl as bounded Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19089: Revert uncrustify fix in types Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> (cherry picked from commit 4fed0bd) # Conflicts: # examples/C++/DDS/ContentFilteredTopicExample/HelloWorld.h # examples/cpp/dds/HelloWorldExampleDataSharing/HelloWorldCdrAux.hpp

* Fix HelloWorld DataSharing example idl (#3714) * Refs #19089: Fix HelloWorld DataSharing example idl as bounded Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19089: Revert uncrustify fix in types Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> (cherry picked from commit 4fed0bd) # Conflicts: # examples/cpp/dds/HelloWorldExampleDataSharing/HelloWorld.h # examples/cpp/dds/HelloWorldExampleDataSharing/HelloWorldCdrAux.hpp * Refs #19089: Fix conflicts (regenerate types with proper fastddsgen & fastcdr versions) Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com> Co-authored-by: JesusPoderoso <jesuspoderoso@eprosima.com>

JesusPoderoso added the no-test Skip CI tests if PR marked with this label label Jul 13, 2023

JesusPoderoso added this to the v2.11.2 milestone Jul 13, 2023

JesusPoderoso self-assigned this Jul 13, 2023

JesusPoderoso added the needs-review PR that is ready to be reviewed label Jul 13, 2023

MiguelCompany modified the milestones: v2.11.2, v2.12.0 Aug 7, 2023

JesusPoderoso force-pushed the hotfix/bounded_string_datasharing_helloworldexample branch from 5febd8a to 071760f Compare September 19, 2023 10:28

JesusPoderoso added ci-pending PR which CI is running and removed needs-review PR that is ready to be reviewed labels Sep 25, 2023

JesusPoderoso force-pushed the hotfix/bounded_string_datasharing_helloworldexample branch from 071760f to 7a2e801 Compare September 25, 2023 09:46

JesusPoderoso changed the base branch from master to feature/xcdr September 25, 2023 09:46

richiware force-pushed the feature/xcdr branch 3 times, most recently from 22a5ed4 to 9c76dcc Compare September 27, 2023 05:55

JesusPoderoso force-pushed the hotfix/bounded_string_datasharing_helloworldexample branch from 7a2e801 to 991cc54 Compare September 27, 2023 07:31

Base automatically changed from feature/xcdr to master September 27, 2023 09:16

JesusPoderoso force-pushed the hotfix/bounded_string_datasharing_helloworldexample branch 2 times, most recently from b214dab to 17ed249 Compare September 27, 2023 10:47

Refs #19089: Fix HelloWorld DataSharing example idl as bounded

a44dcb1

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

JesusPoderoso force-pushed the hotfix/bounded_string_datasharing_helloworldexample branch from 17ed249 to a44dcb1 Compare September 27, 2023 10:50

EduPonz previously approved these changes Sep 27, 2023

View reviewed changes

Refs #19089: Revert uncrustify fix in types

ff8435f

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

JesusPoderoso dismissed EduPonz’s stale review via ff8435f September 27, 2023 13:48

Mario-DL approved these changes Sep 27, 2023

View reviewed changes

EduPonz merged commit 4fed0bd into master Sep 28, 2023
7 of 8 checks passed

EduPonz deleted the hotfix/bounded_string_datasharing_helloworldexample branch September 28, 2023 05:17

This was referenced Sep 28, 2023

[19089] Fix HelloWorld DataSharing example idl (backport #3714) #3884

Merged

[19089] Fix HelloWorld DataSharing example idl (backport #3714) #3885

Merged

[19089] Fix HelloWorld DataSharing example idl (backport #3714) #3886

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[19089] Fix HelloWorld DataSharing example idl #3714

[19089] Fix HelloWorld DataSharing example idl #3714

JesusPoderoso commented Jul 13, 2023 •

edited

Loading

Mario-DL commented Sep 20, 2023

JLBuenoLopez commented Sep 20, 2023

JesusPoderoso commented Sep 20, 2023

mergify bot commented Sep 20, 2023 •

edited

Loading

Mario-DL commented Sep 20, 2023

JesusPoderoso commented Sep 27, 2023

Mario-DL commented Sep 27, 2023

JesusPoderoso commented Sep 27, 2023

Mario-DL left a comment •

edited

Loading

[19089] Fix HelloWorld DataSharing example idl #3714

[19089] Fix HelloWorld DataSharing example idl #3714

Conversation

JesusPoderoso commented Jul 13, 2023 • edited Loading

Description

Contributor Checklist

Reviewer Checklist

Mario-DL commented Sep 20, 2023

JLBuenoLopez commented Sep 20, 2023

JesusPoderoso commented Sep 20, 2023

mergify bot commented Sep 20, 2023 • edited Loading

✅ Backports have been created

Mario-DL commented Sep 20, 2023

JesusPoderoso commented Sep 27, 2023

Mario-DL commented Sep 27, 2023

JesusPoderoso commented Sep 27, 2023

Mario-DL left a comment • edited Loading

Choose a reason for hiding this comment

JesusPoderoso commented Jul 13, 2023 •

edited

Loading

mergify bot commented Sep 20, 2023 •

edited

Loading

Mario-DL left a comment •

edited

Loading