Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19887] Improve IgnoreNonExistentSegment test #4036

Merged
merged 2 commits into from
Nov 24, 2023
Merged

[19887] Improve IgnoreNonExistentSegment test #4036

merged 2 commits into from
Nov 24, 2023

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Nov 21, 2023 •
edited by EduPonz
Loading

Description

Makes the behavior of SHM.IgnoreNonExistentSegment black-box test specific on each platform.

@Mergifyio backport 2.12.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany
Refs #19887. Platform specific behavior on IgnoreNonExistentSegment t…
7a22c26 
…est.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany added this to the v2.13.0 milestone Nov 21, 2023
@MiguelCompany
Refs #19887. Use num_threads in loop.
9fedf58 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@EduPonz EduPonz merged commit d81a024 into master Nov 24, 2023
9 checks passed
@EduPonz EduPonz deleted the hotfix/platform-specific-IgnoreNonExistentSegment-test branch November 24, 2023 06:16
@MiguelCompany MiguelCompany mentioned this pull request Nov 27, 2023
Merged
10 tasks
MiguelCompany added a commit that referenced this pull request Nov 27, 2023
@MiguelCompany
Improve IgnoreNonExistentSegment test (#4036)
fbee189 
* Refs #19887. Platform specific behavior on IgnoreNonExistentSegment test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19887. Use `num_threads` in loop.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany mentioned this pull request Nov 27, 2023
Merged
9 tasks
@elianalf
Copy link
Contributor

@Mergifyio backport 2.12.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 29, 2023 •
edited
Loading

backport 2.12.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 29, 2023
@MiguelCompany @mergify
Improve IgnoreNonExistentSegment test (#4036)
e1e7f23 
* Refs #19887. Platform specific behavior on IgnoreNonExistentSegment test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19887. Use `num_threads` in loop.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit d81a024)
@mergify mergify bot mentioned this pull request Nov 29, 2023
Closed
MiguelCompany added a commit that referenced this pull request Dec 5, 2023
@MiguelCompany
Improve IgnoreNonExistentSegment test (#4036) (#4057)
5d98cee 
* Improve IgnoreNonExistentSegment test (#4036)

* Refs #19887. Platform specific behavior on IgnoreNonExistentSegment test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19887. Use `num_threads` in loop.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Fix warning in Mac rewarding unnecessary lambda capture (#4052)

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MiguelCompany @elianalf @EduPonz