[19967] Define a super client by environment variable #4047

elianalf · 2023-11-23T15:02:34Z

Description

Define a super client setting a new environment variable ROS_SUPER_CLIENT

@Mergifyio backport 2.12.x 2.11.x 2.10.x 2.6.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally; test case: [19967] Define a super client by environment variable Discovery-Server#65
Any new/modified methods have been properly documented using Doxygen.
Changes are ABI compatible.
Changes are API compatible.
N/A New feature has been added to the versions.md file (if applicable).
New feature has been documented/Current behavior is correctly described in the documentation.
Related documentation PR: [19967] Define a super client by environment variable Fast-DDS-docs#596
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

EduPonz · 2023-11-24T06:45:21Z

@richiprosima please test mac

MiguelCompany

Please remove commit b0651d09484806986b63b72f231641ddd21373dc from the history

src/cpp/rtps/builtin/discovery/participant/PDPClient.cpp

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

src/cpp/rtps/builtin/discovery/participant/PDPClient.cpp

elianalf · 2023-11-28T15:32:03Z

@richiprosima please test this

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

MiguelCompany

🏅

MiguelCompany · 2023-11-29T07:08:25Z

@richiprosima Please test this

MiguelCompany · 2023-11-30T08:20:22Z

@Mergifyio backport 2.12.x 2.11.x 2.10.x 2.6.x

mergify · 2023-11-30T08:20:34Z

backport 2.12.x 2.11.x 2.10.x 2.6.x

✅ Backports have been created

#4105 [19967] Define a super client by environment variable (backport #4047) has been created for branch 2.12.x
#4106 [19967] Define a super client by environment variable (backport #4047) has been created for branch 2.11.x
#4107 [19967] Define a super client by environment variable (backport #4047) has been created for branch 2.10.x
#4108 [19967] Define a super client by environment variable (backport #4047) has been created for branch 2.6.x but encountered conflicts

MiguelCompany · 2023-11-30T08:29:29Z

Testing with discovery server changes:

elianalf · 2023-12-04T07:46:24Z

@richiprosima please test windows

EduPonz · 2023-12-05T08:20:36Z

@richiprosima please test windows

* Refs #19967: Add env variable ROS_SUPER_CLIENT Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Make SIMPLE to SUPER CLIENT, when ROS_SUPER_CLIENT is true Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Delete the change Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Add test superhost set by environment variable Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Uncrustify and clean Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Uncrustify and clean Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Document the methods Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Change try-throw-catch in a simple log error Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Change string in log error Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> --------- Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> (cherry picked from commit f40d54c)

* Refs #19967: Add env variable ROS_SUPER_CLIENT Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Make SIMPLE to SUPER CLIENT, when ROS_SUPER_CLIENT is true Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Delete the change Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Add test superhost set by environment variable Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Uncrustify and clean Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Uncrustify and clean Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Document the methods Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Change try-throw-catch in a simple log error Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Change string in log error Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> --------- Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> (cherry picked from commit f40d54c) # Conflicts: # src/cpp/rtps/RTPSDomain.cpp # test/unittest/dds/participant/ParticipantTests.cpp

* Define a super client by environment variable (#4047) * Refs #19967: Add env variable ROS_SUPER_CLIENT Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Make SIMPLE to SUPER CLIENT, when ROS_SUPER_CLIENT is true Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Delete the change Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Add test superhost set by environment variable Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Uncrustify and clean Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Uncrustify and clean Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Document the methods Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Change try-throw-catch in a simple log error Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Change string in log error Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> --------- Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> (cherry picked from commit f40d54c) * Add GET_PID definition to DDS Participant tests Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: elianalf <62831776+elianalf@users.noreply.github.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com>

* Refs #19967: Add env variable ROS_SUPER_CLIENT Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Make SIMPLE to SUPER CLIENT, when ROS_SUPER_CLIENT is true Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Delete the change Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Add test superhost set by environment variable Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Uncrustify and clean Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Uncrustify and clean Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Document the methods Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Change try-throw-catch in a simple log error Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Change string in log error Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> --------- Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> (cherry picked from commit f40d54c) Co-authored-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Refs #19967: Add env variable ROS_SUPER_CLIENT Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Make SIMPLE to SUPER CLIENT, when ROS_SUPER_CLIENT is true Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Delete the change Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Add test superhost set by environment variable Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Uncrustify and clean Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Uncrustify and clean Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Document the methods Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Change try-throw-catch in a simple log error Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Change string in log error Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> --------- Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> (cherry picked from commit f40d54c) # Conflicts: # src/cpp/rtps/RTPSDomain.cpp # test/unittest/dds/participant/ParticipantTests.cpp

* Refs #19967: Add env variable ROS_SUPER_CLIENT Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Make SIMPLE to SUPER CLIENT, when ROS_SUPER_CLIENT is true Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Delete the change Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Add test superhost set by environment variable Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Uncrustify and clean Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Uncrustify and clean Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Document the methods Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Change try-throw-catch in a simple log error Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Change string in log error Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> --------- Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> (cherry picked from commit f40d54c) Co-authored-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Define a super client by environment variable (#4047) * Refs #19967: Add env variable ROS_SUPER_CLIENT Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Make SIMPLE to SUPER CLIENT, when ROS_SUPER_CLIENT is true Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Delete the change Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Add test superhost set by environment variable Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Uncrustify and clean Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Uncrustify and clean Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Document the methods Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Change try-throw-catch in a simple log error Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Change string in log error Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> --------- Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> (cherry picked from commit f40d54c) # Conflicts: # src/cpp/rtps/RTPSDomain.cpp # test/unittest/dds/participant/ParticipantTests.cpp * FIx conflicts Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Define a super client by environment variable (#4047) * Refs #19967: Add env variable ROS_SUPER_CLIENT Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Make SIMPLE to SUPER CLIENT, when ROS_SUPER_CLIENT is true Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Delete the change Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Add test superhost set by environment variable Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Uncrustify and clean Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Uncrustify and clean Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Document the methods Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #19967: Change try-throw-catch in a simple log error Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Change string in log error Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> --------- Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> (cherry picked from commit f40d54c) # Conflicts: # src/cpp/rtps/RTPSDomain.cpp # test/unittest/dds/participant/ParticipantTests.cpp * FIx conflicts Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Solve building issue due to backport Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Apply suggestion Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Fix test for udpv6 Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> --------- Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> Co-authored-by: elianalf <62831776+elianalf@users.noreply.github.com>

elianalf added the doc-pending Issue or PR which is pending to be documented label Nov 23, 2023

elianalf changed the title ~~Feature/19967~~ [19967] Define a super client by environment variable Nov 23, 2023

EduPonz added this to the v2.13.0 milestone Nov 24, 2023

This was referenced Nov 24, 2023

[19967] Define a super client by environment variable eProsima/Fast-DDS-docs#596

Merged

[19967] Define a super client by environment variable eProsima/Discovery-Server#65

Merged

EduPonz added ci-pending PR which CI is running needs-review PR that is ready to be reviewed and removed doc-pending Issue or PR which is pending to be documented labels Nov 27, 2023

MiguelCompany requested changes Nov 28, 2023

View reviewed changes

src/cpp/rtps/builtin/discovery/participant/PDPClient.cpp Outdated Show resolved Hide resolved

elianalf added 7 commits November 28, 2023 09:54

Refs #19967: Add env variable ROS_SUPER_CLIENT

30dd6d7

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

Refs #19967: Make SIMPLE to SUPER CLIENT, when ROS_SUPER_CLIENT is true

7d39461

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

Refs #19967: Delete the change

6830a42

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

Refs #19967: Add test superhost set by environment variable

547cc6c

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

Refs #19967: Uncrustify and clean

4ab4837

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

Refs #19967: Uncrustify and clean

ddbaa69

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

Refs #19967: Document the methods

345980f

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

elianalf force-pushed the feature/19967 branch from 82d3c7f to 345980f Compare November 28, 2023 08:55

Refs #19967: Change try-throw-catch in a simple log error

40e5946

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

elianalf requested a review from MiguelCompany November 28, 2023 10:37

MiguelCompany requested changes Nov 28, 2023

View reviewed changes

src/cpp/rtps/builtin/discovery/participant/PDPClient.cpp Outdated Show resolved Hide resolved

elianalf mentioned this pull request Nov 28, 2023

[20034] Enable-Disable monitor service on shapes demo eProsima/ShapesDemo#96

Merged

MiguelCompany removed the needs-review PR that is ready to be reviewed label Nov 29, 2023

Change string in log error

8d03ef3

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

MiguelCompany approved these changes Nov 29, 2023

View reviewed changes

MiguelCompany added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Nov 30, 2023

MiguelCompany added ci-pending PR which CI is running and removed ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. labels Nov 30, 2023

EduPonz merged commit f40d54c into master Dec 5, 2023
12 of 14 checks passed

EduPonz deleted the feature/19967 branch December 5, 2023 15:19

mergify bot mentioned this pull request Dec 5, 2023

[19967] Define a super client by environment variable (backport #4047) #4105

Merged

This was referenced Dec 5, 2023

[19967] Define a super client by environment variable (backport #4047) #4106

Merged

[19967] Define a super client by environment variable (backport #4047) #4107

Merged

mergify bot mentioned this pull request Dec 5, 2023

[19967] Define a super client by environment variable (backport #4047) #4108

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[19967] Define a super client by environment variable #4047

[19967] Define a super client by environment variable #4047

elianalf commented Nov 23, 2023 •

edited by MiguelCompany

Loading

EduPonz commented Nov 24, 2023

MiguelCompany left a comment

elianalf commented Nov 28, 2023

MiguelCompany left a comment

MiguelCompany commented Nov 29, 2023

MiguelCompany commented Nov 30, 2023

mergify bot commented Nov 30, 2023 •

edited

Loading

MiguelCompany commented Nov 30, 2023 •

edited

Loading

elianalf commented Dec 4, 2023

EduPonz commented Dec 5, 2023

[19967] Define a super client by environment variable #4047

[19967] Define a super client by environment variable #4047

Conversation

elianalf commented Nov 23, 2023 • edited by MiguelCompany Loading

Description

Contributor Checklist

Reviewer Checklist

EduPonz commented Nov 24, 2023

MiguelCompany left a comment

Choose a reason for hiding this comment

elianalf commented Nov 28, 2023

MiguelCompany left a comment

Choose a reason for hiding this comment

MiguelCompany commented Nov 29, 2023

MiguelCompany commented Nov 30, 2023

mergify bot commented Nov 30, 2023 • edited Loading

✅ Backports have been created

MiguelCompany commented Nov 30, 2023 • edited Loading

elianalf commented Dec 4, 2023

EduPonz commented Dec 5, 2023

elianalf commented Nov 23, 2023 •

edited by MiguelCompany

Loading

mergify bot commented Nov 30, 2023 •

edited

Loading

MiguelCompany commented Nov 30, 2023 •

edited

Loading