Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When I select Filter Lines: Include ... (either string or regex) nothing happens with a large file #34

Closed
bradlitterell opened this issue May 10, 2024 · 4 comments

Comments

@bradlitterell
Copy link

bradlitterell commented May 10, 2024

When trying to filter a large file (6 million lines). nothing happens, I never get the opportunity to input a filter expression/string. I simply get dropped back in my 6 million line log file.

With smaller text files the extension seems to work, but inability to use it on large files defeats the purpose.

@earshinov
Copy link
Owner

earshinov commented May 10, 2024

Hey @bradlitterell! The absence of a prompt window suggests that VS Code doesn't even get to executing the extension's code. The extension registers a text editor command, and VS Code needs to set up an editing context so that the extension could do its job. With 6 million lines, this preparatory work alone take too much time. I would say, such an amount warrants using separate tools rather than relying solely on an IDE...

@sbenben
Copy link

sbenben commented Jan 3, 2025

Same behaviour here also with a rather big file (800.000 lines), in the output of extension host I get a warning:

2025-01-03 15:07:20.031 [warning] Cannot execute filterlines.includeLinesWithString because there is no active text editor.

If this is a limitation of VSC, the only thing I could dream of would be a notification instead of "nothing happens" :)

@earshinov
Copy link
Owner

Apparently it is an old issue in VS Code...
microsoft/vscode#31078 (comment)

@bradlitterell
Copy link
Author

Thanks for the reference. Closing this as not-planned.

@bradlitterell bradlitterell closed this as not planned Won't fix, can't repro, duplicate, stale Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants