Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests fail due to check_accepted_eula #2296

Closed
SebastianAchilles opened this issue Dec 28, 2020 · 1 comment
Closed

Unit tests fail due to check_accepted_eula #2296

SebastianAchilles opened this issue Dec 28, 2020 · 1 comment
Milestone

Comments

@SebastianAchilles
Copy link
Member

EasyBlocks that make use of the function check_accepted_eula (easybuilders/easybuild-framework#3535) will fail in the Unit tests, because the EULA is not accepted. This is the case for #2295

One possible solution would be to set the environment variable EASYBUILD_ACCEPT_EULA for that specific EasyBlock in the Unit test.

Another possible solution would be to include in accept_eula = True in the Dummy easyconfig file, e.g. here

Another possible solution would be to skip the check_accepted_eula function for --module-only.

CC @boegel

@SebastianAchilles
Copy link
Member Author

I think the last option is the best. This can be done very easily by moving check_accepted_eula to the install_step. In that case the check is not executed for --module-only and the Unit test is passed.

@boegel boegel added this to the 4.x milestone Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants