Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add custom easyblock for CRISPR-DAV #2487

Merged
merged 5 commits into from
Aug 19, 2021
Merged

add custom easyblock for CRISPR-DAV #2487

merged 5 commits into from
Aug 19, 2021

Conversation

deniskristak
Copy link
Contributor

needed to create easyblock due to complex source file changes

@deniskristak deniskristak mentioned this pull request Jun 23, 2021
Merged
@boegel boegel added the new label Jun 23, 2021
@boegel boegel added this to the 4.x milestone Jun 23, 2021
@boegel boegel changed the title easyblock for crisprdav software add custom easyblock for CRISPR-DAV Jun 28, 2021
boegel
boegel requested changes Jun 28, 2021
View reviewed changes
easybuild/easyblocks/c/crisprdav.py Outdated Show resolved Hide resolved
easybuild/easyblocks/c/crisprdav.py Outdated Show resolved Hide resolved
easybuild/easyblocks/c/crisprdav.py Outdated Show resolved Hide resolved
easybuild/easyblocks/c/crisprdav.py Outdated Show resolved Hide resolved
easybuild/easyblocks/c/crisprdav.py Outdated Show resolved Hide resolved
easybuild/easyblocks/c/crisprdav.py Outdated Show resolved Hide resolved
easybuild/easyblocks/c/crisprdav.py Outdated Show resolved Hide resolved
easybuild/easyblocks/c/crisprdav.py Outdated Show resolved Hide resolved
@verdurin
Copy link
Member

verdurin commented Jul 5, 2021

@deniskristak I tried building the associated easyconfig and saw this error:

eb --from-pr=13139 --robot --debug --upload-test-report --include-easyblocks-from-pr 2487
== Temporary log file in case of crash /tmp/eb-jdvm00ah/easybuild-q0xclof4.log
== easyblock crispr_dav.py included from PR #2487
ERROR: Failed to process easyconfig /tmp/eb-jdvm00ah/files_pr13139/c/crispr-dav/crispr-dav-2.3.4-foss-2020b.eb: Failed to obtain class for EB_crisprdav easyblock (not available?): No module named 'easybuild.easyblocks.crisprdav'

@deniskristak
Copy link
Contributor Author

@verdurin correct, i forgot to remove an easyconfig with an the old name. Should be working now

@boegel
Copy link
Member

boegel commented Aug 18, 2021

close/re-open to wake up GitHub Actions...

@boegel boegel closed this Aug 18, 2021
@boegel boegel reopened this Aug 18, 2021
@boegel boegel modified the milestones: 4.x, next release (4.4.2?) Aug 19, 2021
@boegel boegel merged commit 3c785c8 into easybuilders:develop Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
new
Projects
None yet
Milestone
4.4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@deniskristak @verdurin @boegel