Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace run_cmd with run_shell_cmd in custom easyblock for Rust (rust.py) #3146

Merged
merged 1 commit into from
Feb 11, 2024
Merged

replace run_cmd with run_shell_cmd in custom easyblock for Rust (rust.py) #3146

merged 1 commit into from
Feb 11, 2024

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Feb 3, 2024 •
edited
Loading

(created using eb --new-pr)

  • no use of EB_Rust in easyconfigs or blocks

@branfosj branfosj mentioned this pull request Feb 3, 2024
Closed
@branfosj branfosj added this to the 5.0 milestone Feb 3, 2024
@branfosj branfosj added change EasyBuild-5.0 EasyBuild 5.0 labels Feb 3, 2024
@jfgrimm
Copy link
Member

jfgrimm commented Feb 6, 2024 •
edited by boegel
Loading

Test report by @jfgrimm

Overview of tested easyconfigs (in order)

  • SUCCESS Rust-1.70.0-GCCcore-12.3.0.eb
  • SUCCESS Rust-1.65.0-GCCcore-12.2.0.eb
  • SUCCESS Rust-1.65.0-GCCcore-11.3.0.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
node093.viking2.yor.alces.network - Linux Rocky Linux 8.8, x86_64, AMD EPYC 7643 48-Core Processor, Python 3.6.8
See https://gist.github.com/jfgrimm/714dab8812cd008187e49271e713d627 for a full test report.

edit: tested with --rpath

boegel
boegel approved these changes Feb 11, 2024
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Feb 11, 2024

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS Rust-1.52.1-GCCcore-10.3.0.eb
  • SUCCESS Rust-1.75.0-GCCcore-12.2.0.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3557.doduo.os - Linux RHEL 8.8, x86_64, AMD EPYC 7552 48-Core Processor, Python 3.6.8
See https://gist.github.com/boegel/6c4ee6bcbff56219df004876049275bc for a full test report.

@boegel boegel merged commit 4bd8097 into easybuilders:5.0.x Feb 11, 2024
17 checks passed
@branfosj branfosj deleted the 20240203112042_new_pr_rust branch February 11, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
change EasyBuild-5.0 EasyBuild 5.0
Projects
EasyBuild v5.0
Status: No status
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@branfosj @jfgrimm @boegel