Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace run_cmd with run_shell_cmd in custom easyblock for QScintilla (qscintilla.py) #3150

Merged

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Feb 3, 2024

(created using eb --new-pr)

  • no use of EB_QScintilla in easyconfigs or blocks

@branfosj
Copy link
Member Author

branfosj commented Feb 3, 2024

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS QScintilla-2.11.6-GCCcore-11.2.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0105u03b - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/1c82d3fd91222f09dc1db1b9a0a82214 for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 3306774 into easybuilders:5.0.x Feb 11, 2024
17 checks passed
@branfosj branfosj deleted the 20240203115013_new_pr_qscintilla branch February 11, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants