Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace run_cmd with run_shell_cmd in custom easyblock for dm-reverb (dm_reverb.py) #3153

Merged
merged 1 commit into from
Feb 9, 2024
Merged

replace run_cmd with run_shell_cmd in custom easyblock for dm-reverb (dm_reverb.py) #3153

merged 1 commit into from
Feb 9, 2024

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Feb 3, 2024 •
edited
Loading

(created using eb --new-pr)

  • no use of EB_dm_minus_reverb in easyconfigs or blocks

@branfosj branfosj added this to the 5.0 milestone Feb 3, 2024
@branfosj branfosj added change EasyBuild-5.0 EasyBuild 5.0 labels Feb 3, 2024
@branfosj branfosj mentioned this pull request Feb 3, 2024
Closed
@branfosj
Copy link
Member Author

branfosj commented Feb 3, 2024

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS gRPC-1.44.0-GCCcore-11.2.0.eb
  • SUCCESS dm-reverb-0.7.0-foss-2021b.eb
  • SUCCESS dm-tree-0.1.5-GCCcore-10.2.0.eb
  • SUCCESS flatbuffers-1.12.0-GCCcore-10.2.0.eb
  • SUCCESS JsonCpp-1.9.4-GCCcore-10.2.0.eb
  • SUCCESS nsync-1.24.0-GCCcore-10.2.0.eb
  • SUCCESS flatbuffers-python-1.12-GCCcore-10.2.0.eb
  • SUCCESS TensorFlow-2.4.1-foss-2020b.eb
  • SUCCESS dm-reverb-0.2.0-foss-2020b.eb

Build succeeded for 9 out of 9 (2 easyconfigs in total)
bear-pg0105u03b - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/1bde00248876407b903d2b0fbbfcb797 for a full test report.

jfgrimm
jfgrimm approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jfgrimm jfgrimm merged commit 74a3937 into easybuilders:5.0.x Feb 9, 2024
17 checks passed
@branfosj branfosj deleted the 20240203124733_new_pr_dm_reverb branch February 9, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfgrimm jfgrimm jfgrimm approved these changes

Assignees
No one assigned
Labels
change EasyBuild-5.0 EasyBuild 5.0
Projects
EasyBuild v5.0
Status: No status
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@branfosj @jfgrimm