Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace run_cmd with run_shell_cmd in custom easyblock for Trinity (trinity.py) #3190

Merged
merged 1 commit into from
Feb 11, 2024
Merged

replace run_cmd with run_shell_cmd in custom easyblock for Trinity (trinity.py) #3190

merged 1 commit into from
Feb 11, 2024

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Feb 8, 2024 •
edited
Loading

(created using eb --new-pr)

  • no use of EB_Trinity in easyconfigs or blocks

@branfosj branfosj added this to the 5.0 milestone Feb 8, 2024
@branfosj branfosj added change EasyBuild-5.0 EasyBuild 5.0 labels Feb 8, 2024
@branfosj branfosj mentioned this pull request Feb 8, 2024
Closed
@branfosj
Copy link
Member Author

branfosj commented Feb 8, 2024

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS Trinity-2.15.1-foss-2022a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0105u03b - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/2606f98c09f2e5744b0439c419bb2e3f for a full test report.

boegel
boegel approved these changes Feb 11, 2024
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Feb 11, 2024

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS Trinity-2.9.1-foss-2020b.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3557.doduo.os - Linux RHEL 8.8, x86_64, AMD EPYC 7552 48-Core Processor, Python 3.6.8
See https://gist.github.com/boegel/10c2f36d6cff072a387b894703e540ad for a full test report.

@boegel boegel merged commit 844384b into easybuilders:5.0.x Feb 11, 2024
17 checks passed
@branfosj branfosj deleted the 20240208183807_new_pr_trinity branch February 11, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
change EasyBuild-5.0 EasyBuild 5.0
Projects
EasyBuild v5.0
Status: No status
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@branfosj @boegel