Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace run_cmd with run_shell_cmd in custom easyblock for MCR (mcr.py) #3213

Merged
merged 1 commit into from
Feb 29, 2024
Merged

replace run_cmd with run_shell_cmd in custom easyblock for MCR (mcr.py) #3213

merged 1 commit into from
Feb 29, 2024

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Feb 10, 2024 •
edited
Loading

(created using eb --new-pr)

  • no use of EB_MCR in easyconfigs or blocks

@branfosj branfosj mentioned this pull request Feb 10, 2024
Closed
@branfosj branfosj added this to the 5.0 milestone Feb 10, 2024
@branfosj
Copy link
Member Author

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS MCR-R2020a.6.eb
  • SUCCESS MCR-R2023a.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/a5a45c0d12720cc660bb0b8fd1ac7ccf for a full test report.

bartoldeman
bartoldeman approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartoldeman bartoldeman merged commit ecf2a40 into easybuilders:5.0.x Feb 29, 2024
17 checks passed
@branfosj branfosj deleted the 20240210095929_new_pr_mcr branch February 29, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartoldeman bartoldeman bartoldeman approved these changes

Assignees
No one assigned
Labels
change EasyBuild-5.0 EasyBuild 5.0
Projects
EasyBuild v5.0
Status: No status
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@branfosj @bartoldeman