Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use run_shell_cmd in custom easyblock for CUDA #3274

Merged
merged 2 commits into from
Apr 6, 2024
Merged

use run_shell_cmd in custom easyblock for CUDA #3274

merged 2 commits into from
Apr 6, 2024

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Apr 4, 2024 •
edited by boegel
Loading

@branfosj branfosj mentioned this pull request Apr 4, 2024
Closed
@branfosj
Copy link
Member Author

branfosj commented Apr 4, 2024

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS CUDA-11.5.2.eb
  • SUCCESS CUDA-12.2.2.eb
  • SUCCESS CUDA-11.8.0.eb
  • SUCCESS CUDA-11.6.0.eb

Build succeeded for 4 out of 4 (4 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/d55efc0d0f1ac94979bb4207d43cdec8 for a full test report.

@Micket Micket added the EasyBuild-5.0 EasyBuild 5.0 label Apr 5, 2024
@Micket Micket added this to the 5.0 milestone Apr 5, 2024
boegel
boegel requested changes Apr 6, 2024
View reviewed changes
easybuild/easyblocks/c/cuda.py Outdated Show resolved Hide resolved
boegel
boegel approved these changes Apr 6, 2024
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Apr 6, 2024

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS CUDA-12.4.0.eb
  • SUCCESS CUDA-12.3.2.eb
  • SUCCESS CUDA-11.7.0.eb
  • SUCCESS CUDA-11.3.1.eb
  • SUCCESS CUDA-11.4.1.eb

Build succeeded for 5 out of 5 (5 easyconfigs in total)
node3563.doduo.os - Linux RHEL 8.8, x86_64, AMD EPYC 7552 48-Core Processor, Python 3.6.8
See https://gist.github.com/boegel/1c04f92ab1d1756f07f1189f60ea8d0d for a full test report.

@boegel boegel merged commit a14a292 into easybuilders:5.0.x Apr 6, 2024
19 checks passed
@branfosj branfosj deleted the 20240404140653_new_pr_cuda branch April 6, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
EasyBuild-5.0 EasyBuild 5.0
Projects
EasyBuild v5.0
Status: No status
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@branfosj @boegel @Micket