Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use run_shell_cmd in custom easyblock for Stata #3288

Merged
merged 2 commits into from
Apr 9, 2024
Merged

use run_shell_cmd in custom easyblock for Stata #3288

merged 2 commits into from
Apr 9, 2024

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Apr 6, 2024

(created using eb --new-pr)

@branfosj branfosj mentioned this pull request Apr 6, 2024
Closed
@branfosj branfosj added change EasyBuild-5.0 EasyBuild 5.0 labels Apr 6, 2024
@branfosj branfosj added this to the 5.0 milestone Apr 6, 2024
@branfosj
Copy link
Member Author

branfosj commented Apr 6, 2024

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS Stata-17.rev2023-01-10.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/dec649e9d709c001d2305f8183dea2fd for a full test report.

boegel
boegel approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Apr 9, 2024

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS Stata-18.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3563.doduo.os - Linux RHEL 8.8, x86_64, AMD EPYC 7552 48-Core Processor, Python 3.6.8
See https://gist.github.com/boegel/a1b3ea44772836085bf024ea7c07d7b1 for a full test report.

@boegel boegel merged commit 632dce9 into easybuilders:5.0.x Apr 9, 2024
19 checks passed
@branfosj branfosj deleted the 20240406134114_new_pr_stata branch April 9, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
change EasyBuild-5.0 EasyBuild 5.0
Projects
EasyBuild v5.0
Status: No status
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@branfosj @boegel