Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use run_shell_cmd (and use f-strings) in custom easyblock for GAMESS-US #3342

Merged
merged 2 commits into from
May 30, 2024
Merged

use run_shell_cmd (and use f-strings) in custom easyblock for GAMESS-US #3342

merged 2 commits into from
May 30, 2024

Conversation

lexming
Copy link
Contributor

@lexming lexming commented May 29, 2024 •
edited
Loading

Changelog:

  • replace run_cmd with run_shell_cmd
  • use f-strings to format text

@lexming lexming added the EasyBuild-5.0 EasyBuild 5.0 label May 29, 2024
@lexming lexming added this to the 5.0 milestone May 29, 2024
@lexming
Copy link
Contributor Author

lexming commented May 29, 2024

Test report by @lexming

Overview of tested easyconfigs (in order)

  • SUCCESS GAMESS-US-20230930-R2-gompi-2022a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node301.hydra.os - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/lexming/e87a8086eadac1973c093120a979132e for a full test report.

boegel
boegel approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title Make GAMESS-US easyblock compliant with EasyBuild 5.0 use run_shell_cmd (and use f-strings) in custom easyblock for GAMESS-US May 30, 2024
@boegel boegel merged commit 3f8fccd into easybuilders:5.0.x May 30, 2024
19 checks passed
@branfosj
Copy link
Member

Part of #3089

@branfosj branfosj mentioned this pull request May 30, 2024
Closed
@lexming lexming deleted the gamess-5.0 branch May 30, 2024 10:36
@boegel boegel added the change label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
change EasyBuild-5.0 EasyBuild 5.0
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lexming @branfosj @boegel