Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure separate_build_dir is set to False for ITK and elastix components in SimpleElastix easyconfig #10300

Merged
merged 1 commit into from
Apr 1, 2020
Merged

ensure separate_build_dir is set to False for ITK and elastix components in SimpleElastix easyconfig #10300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions easybuild/easyconfigs/s/SimpleElastix/SimpleElastix-1.1.0-foss-2019b-Python-3.7.4.eb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,9 @@ components = [
'source_urls': ['https://github.com/InsightSoftwareConsortium/ITK/archive/'],
'checksums': ['c6b3c33ecc73104c906e0e1a1bfaa41a09af24bf53a4ec5e5c265d7e82bdf69f'],
'srcdir': '%%(builddir)s/ITK-%s' % local_itk_ver,
# we need to take matters into our own hands here to ensure we have a unique build directory per component;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if it wouldn't be better if this is done in the CMakeMake EB. Currently the build folders are %(start_dir)s/easybuild_obj for these components, aren't they? How about instead if using %(builddir)s/easybuild_obj we use %(builddir)s/easybuild_obj_%(name)s or so?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, that's also an option I guess, yeah...

But let's make that a separate PR, I don't want to block easybuilders/easybuild-easyblocks#1933 over this.

# by default, CMakeMake will (re)use %(builddir)s/easybuild_obj, which causes trouble
'separate_build_dir': False,
'preconfigopts': "mkdir easybuild_obj && cd easybuild_obj && Eigen3_DIR=$EBROOTEIGEN ",
'configopts': local_itk_configopts,
'prebuildopts': "cd easybuild_obj && ",
Expand All @@ -87,6 +90,7 @@ components = [
}],
'checksums': ['a377ae0307231bf70c474e87ebbf07d649faca211febf1c1d981a2039fcfcd0e'],
'srcdir': '%%(builddir)s/elastix-%s' % local_elastix_ver,
'separate_build_dir': False,
'preconfigopts': "mkdir easybuild_obj && cd easybuild_obj && ",
'configopts': local_elastix_configopts,
'prebuildopts': "cd easybuild_obj && ",
Expand Down