Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{lib}[system/system] NCCL v2.10.3 #13405

Conversation

robert-mijakovic
Copy link
Contributor

@robert-mijakovic robert-mijakovic commented Jul 9, 2021

(created using eb --new-pr)
Depends on:

@robert-mijakovic
Copy link
Contributor Author

@boegelbot please test @ generoso EB_ARGS="--from-pr 13301"

@boegelbot
Copy link
Collaborator

@robert-mijakovic: Request for testing this PR well received on generoso

PR test command 'EB_PR=13405 EB_ARGS="--from-pr 13301" /apps/slurm/default/bin/sbatch --job-name test_PR_13405 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 17754

Test results coming soon (I hope)...

- notification for comment with ID 877589011 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@Micket
Copy link
Contributor

Micket commented Jul 12, 2021

Not sure we still want the binary version instead of compiling it.

@robert-mijakovic
Copy link
Contributor Author

@Micket Ok. I will prepare the compiled version.

@Micket
Copy link
Contributor

Micket commented Jul 14, 2021

Already open #13282
Just waiting for the decision on #12484

@Flamefire
Copy link
Contributor

Not sure we still want the binary version instead of compiling it.

I'd always go for compiling as it allows adding patches if we need it. Hence my suggestion to close this in favor of #13282

@robert-mijakovic
Copy link
Contributor Author

Not sure we still want the binary version instead of compiling it.

I'd always go for compiling as it allows adding patches if we need it. Hence my suggestion to close this in favor of #13282

I agree, thus closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants