Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build libtinfo and multithreaded targets of ncurses #15897

Closed

Conversation

lexming
Copy link
Contributor

@lexming lexming commented Jul 22, 2022

(created using eb --new-pr)

Changelog:

  • properly build libtinfo with --with-termlib instead of symlinking, this results in two smaller libraries instead of a single big one
  • add multithreaded versions of ncurses

This PR brings all easyconfigs of ncurses in the SYSTEM toolchain and all easyconfigs of ncurses v6.2 (last version) to the same state.

@lexming
Copy link
Contributor Author

lexming commented Jul 22, 2022

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=15897 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15897 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8894

Test results coming soon (I hope)...

- notification for comment with ID 1192621780 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 8 out of 8 (8 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/212f031bea48b1deba3e20a2a9e6c33e for a full test report.

@lexming
Copy link
Contributor Author

lexming commented Jul 22, 2022

I was not aware of #3545 (comment), so I'm not the first one that made the split of libtinfo. I'll put this PR on hold to explore the old issues with this change,

@lexming lexming marked this pull request as draft July 22, 2022 15:21
@lexming
Copy link
Contributor Author

lexming commented Jul 22, 2022

Apparently I opened pandora's box without knowing. I thought that --with-termlib did just cleanly split the symbols between libncurses and libtinfo, as libncurses does dynamically link to libtinfo. In fact, not all symbols in libtinfo are referenced in libncurses and that is the source of all previous issues. So, symlinking is definitely the best solution. Scratching this PR. 🙂

@lexming lexming closed this Jul 22, 2022
@lexming lexming added this to the next release (4.6.1?) milestone Jul 22, 2022
@lexming lexming deleted the 20220722154624_new_pr_ncurses59 branch July 22, 2022 21:59
@lexming lexming restored the 20220722154624_new_pr_ncurses59 branch July 22, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants