Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing hatchling build dependency for epiScanpy 0.4.0 w/ foss/2023a #21809

Merged

Conversation

boegel
Copy link
Member

@boegel boegel commented Nov 8, 2024

(created using eb --new-pr)

hatchling was removed an run-time dependency for scanpy in #21657, which is a dependency of epiScanpy, and it's required by the legacy_api_wrap extension included in epiScanpy

@boegel boegel added the bug fix label Nov 8, 2024
@boegel boegel added this to the release after 4.9.4 milestone Nov 8, 2024
@github-actions github-actions bot added the change label Nov 8, 2024
@boegel
Copy link
Member Author

boegel commented Nov 8, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=21809 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21809 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14663

Test results coming soon (I hope)...

- notification for comment with ID 2464439516 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/6932f2e4e214d80dc646f7c29ffa97c5 for a full test report.

@boegel
Copy link
Member Author

boegel commented Nov 8, 2024

@boegelbot please test @ jsc-zen3

@boegel
Copy link
Member Author

boegel commented Nov 8, 2024

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node4003.donphan.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz, 1 x NVIDIA NVIDIA A2, 545.23.08, Python 3.6.8
See https://gist.github.com/boegel/007ba32b14e19fe56e69f992f4216ad8 for a full test report.

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21809 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21809 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5227

Test results coming soon (I hope)...

- notification for comment with ID 2464468754 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/a9e1a0d64269b0eff79da4919f87209d for a full test report.

Copy link
Contributor

@laraPPr laraPPr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@laraPPr
Copy link
Contributor

laraPPr commented Nov 8, 2024

Test report by @laraPPr
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3163.skitty.os - Linux RHEL 9.4 (Plow), x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.9.18
See https://gist.github.com/laraPPr/5bb6a67eddf9289527c34f408ab13db1 for a full test report.

@laraPPr
Copy link
Contributor

laraPPr commented Nov 8, 2024

Going in, thanks @boegel!

@laraPPr laraPPr merged commit aeaf26d into easybuilders:develop Nov 8, 2024
10 checks passed
@boegel boegel deleted the 20241108121320_new_pr_epiScanpy040 branch November 8, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants