Merge pull request #4721 from branfosj/extended_dry_run

make sure `type module` is run during a dry run
easybuilders · Dec 11, 2024 · 1de2441 · 1de2441
2 parents 5e01424 + acd1cda
commit 1de2441
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.github/workflows/end2end.yml b/.github/workflows/end2end.yml
@@ -56,6 +56,7 @@ jobs:
             "eb --show-system-info"
             "eb --check-eb-deps"
             "eb --show-config"
+            "eb -x bzip2-1.0.8.eb"
           )
           for cmd in "${cmds[@]}"; do
               echo ">>> $cmd"

diff --git a/easybuild/tools/modules.py b/easybuild/tools/modules.py
@@ -308,7 +308,7 @@ def check_module_function(self, allow_mismatch=False, regex=None):
                 output, exit_code = None, EasyBuildExit.FAIL_SYSTEM_CHECK
         else:
             cmd = "type module"
-            res = run_shell_cmd(cmd, fail_on_error=False, in_dry_run=False, hidden=True, output_file=False)
+            res = run_shell_cmd(cmd, fail_on_error=False, in_dry_run=True, hidden=True, output_file=False)
             output, exit_code = res.output, res.exit_code
 
         if regex is None:
@@ -1367,7 +1367,7 @@ def check_module_function(self, allow_mismatch=False, regex=None):
                 out, ec = None, 1
         else:
             cmd = "type _module_raw"
-            res = run_shell_cmd(cmd, fail_on_error=False, in_dry_run=False, hidden=True, output_file=False)
+            res = run_shell_cmd(cmd, fail_on_error=False, in_dry_run=True, hidden=True, output_file=False)
             out, ec = res.output, res.exit_code
 
         if regex is None: