Fix @boegel's remarks

easybuilders · Oct 27, 2015 · 31b2a54 · 31b2a54
1 parent 06abf77
commit 31b2a54
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/easybuild/tools/filetools.py b/easybuild/tools/filetools.py
@@ -701,15 +701,16 @@ def adjust_permissions(name, permissionBits, add=True, onlyfiles=False, onlydirs
             paths = []
             if not onlydirs:
                 if not skip_symlinks:
-                    paths += files
+                    paths.extend(files)
                 else:
                     for path in files:
-                        fname = os.path.join(root, path)
-                        if not os.path.islink(fname):
+                        if not os.path.islink(os.path.join(root, path)):
                             paths.append(path)
+                        else:
+                            _log.debug("Not adjusting permissions for symlink %s", path)
             if not onlyfiles:
                 # os.walk skips symlinked dirs by default, i.e., no special handling needed here
-                paths += dirs
+                paths.extend(dirs)
 
             for path in paths:
                 allpaths.append(os.path.join(root, path))