Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eb --new-pr without github username should return clearer message #3615

Closed
robert-mijakovic opened this issue Mar 17, 2021 · 1 comment
Closed
Milestone

Comments

@robert-mijakovic
Copy link

I had an issue where eb --new-pr was used without github username and it returned the following message:

ERROR: Failed to push branch '20210317112849_new_pr_AOCC300' to GitHub (git@github.com:None/easybuild-easyconfigs.git): Cmd('git') failed due to: exit code(128)
cmdline: git push --porcelain github_None_qnHqP 20210317112849_new_pr_AOCC300
stderr: 'fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.'

As you can see None was set instead of the username and the message is quite cryptic.
I think it should be handled that when None is set and exit code from git is 128 it should print that github username is not set.

@migueldiascosta migueldiascosta added this to the 4.x milestone Mar 18, 2021
@migueldiascosta
Copy link
Member

fixed in #3644 (and #3681 addresses a similar problem in --check-github)

@boegel boegel modified the milestones: 4.x, 4.4.0 Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants