Code

add support for --review-pr#1142

Code

Closed

boegel wants to merge 63 commits intoeasybuilders:mastereasybuilders/easybuild-framework:masterfrom boegel:feature/add-review-pr-optionboegel/easybuild-framework:feature/add-review-pr-optionCopy head branch name to clipboard

+563-62

Commits

Commits on Aug 13, 2014

• add download_repo() method

  

  Toon Willems

  committed
  dbed38c

• compare push

  

  Toon Willems

  committed
  b3eef1f

• change outputter

  

  Toon Willems

  committed
  7dbbffb

• add tool to determine terminal size

  

  Toon Willems

  committed
  839e716

• don't need no ordering

  

  Toon Willems

  committed
  422f5d1

• some minor fixes

  

  Toon Willems

  committed
  01325ee

• fix exact matching

  

  Toon Willems

  committed
  e7f0386

Commits on Aug 14, 2014

• move review code to dedicated module

  

  Toon Willems

  committed
  f92fffb

• add SO reference to terminal.py

  

  Toon Willems

  committed
  fc672b6

• improve logging, make download_repo generic

  

  Toon Willems

  committed
  e3c3255

• cleanup find_related_easyconfigs

  

  Toon Willems

  committed
  e4be300

• add header, general cleanup of multi_diff

  

  Toon Willems

  committed
  31b43d3

• remove unneeded whitespace in main.py

  

  Toon Willems

  committed
  587976b

• use setdefault, __str__

  

  Toon Willems

  committed
  5fb9d5d

• change to positive logic

  

  Toon Willems

  committed
  88f118b

• use constant instead of random strings

  

  Toon Willems

  committed
  10d5256

• add header, note about failing imports

  

  Toon Willems

  committed
  bdc096c

• creative use of setdefault

  

  Toon Willems

  committed
  7daded0

• wrap long line

  

  Toon Willems

  committed
  994f3eb

• remove 2/3 _download references

  

  Toon Willems

  committed
  fe05cf1

• cleanup sorting / filtering

  

  Toon Willems

  committed
  ce87340

• cleanup ifs

  

  Toon Willems

  committed
  f80be4e

• fix colorize

  

  Toon Willems

  committed
  702c811

• add support to disable colors

  

  Toon Willems

  committed
  9b69d78

• add check for not redownloading github archive

  

  Toon Willems

  committed
  841cc44

• add some docstrings

  

  Toon Willems

  committed
  78bd67e

• change some docstrings around

  

  Toon Willems

  committed
  27d2709

• syntax error

  

  Toon Willems

  committed
  30a2774

• copyright year

  

  Toon Willems

  committed
  2ef71c0

• fix all the things

  

  Toon Willems

  committed
  46ca7e3

Commits on Jan 10, 2015

• Merge branch 'develop' into feature/add-review-pr-option

  Show description for cf64b86
  boegel

  committed
  cf64b86

• tiny fixes in github.py

  boegel

  committed
  438e7e4

• fix exit for --review-pr

  boegel

  committed
  3d7b65b

• bump to 2015 in copyright line in new modules

  boegel

  committed
  af6da72

• fix passing of 'per_page=GITHUB_MAX_PER_PAGE' to _do_request

  boegel

  committed
  1aa2eac

• move review_pr function to framework.easyconfig.tools module

  boegel

  committed
  2c46169

• parse easyconfigs before passing them down to find_related_easyconfigs

  boegel

  committed
  ee2fee1

• fix/cleanup in find_related_easyconfigs: only consider easyconfig files with same name, also consider versionsuffix and major/minor software version, only return non-empty list (unless there's no s…

  Show description for 4a6d7b2
  boegel

  committed
  4a6d7b2

• minor enhancements in review_pr function

  boegel

  committed
  61e07fa

• don't validate easyconfigs when reviewing PRs

  boegel

  committed
  07de284

• use raw strings for regex patterns

  boegel

  committed
  9ddb85f

• some style cleanup in multi_diff.py

  boegel

  committed
  fb86a63

• move find_related_easyconfigs into framework.easyconfigs.tools + minor enhancements

  boegel

  committed
  6af5f39

• replace easybuild.tools.terminal module with simple det_terminal_size function in tools.utilities

  boegel

  committed
  b3c2dce

• fix location of --review-pr and --color options

  boegel

  committed
  9859dac

• style cleanup in tools/github.py

  boegel

  committed
  d84b1fe

Commits on Jan 12, 2015

• minor tweaks in docstring + some cleanup in review_pr function

  boegel

  committed
  47e1ba3

• fix use of review_pr in main.py, style cleanup in multi_diff.py

  boegel

  committed
  61b687c

• rename multi_diff to multidiff

  boegel

  committed
  48b89c0

Commits on Jan 16, 2015

• fix import order

  boegel

  committed
  cb1e911

• style fixes in multidiff.py

  boegel

  committed
  dc6cbc1

Commits on Jan 20, 2015

• style fixes in multidiff.py

  boegel

  committed
  e9373bd

Commits on Apr 3, 2015

• Merge branch 'develop' into feature/add-review-pr-option

  Show description for 4744fbb
  boegel

  committed
  4744fbb

• stop using log.error in multidiff.py

  boegel

  committed
  33a8e65

Commits on Sep 2, 2015

• bump version to 2.3.1dev

  boegel

  committed
  c407580

• bump version to 2.4.0dev

  boegel

  committed
  7f45f71

• Merge branch 'master' into develop

  boegel

  committed
  30f2908

• Merge branch 'develop' into feature/add-review-pr-option

  boegel

  committed
  a165461

Commits on Sep 3, 2015

• fix extracting of comments from an easyconfig file that includes 'tail' comments

  boegel

  committed
  87eb367

• add tail comment in test easyconfig

  boegel

  committed
  2def3b1

Commits on Sep 4, 2015

• enhance test_dump_comments with trailing comment

  boegel

  committed
  07989fe

• Merge pull request easybuilders#1381 from boegel/fix_extract_tail_comment

  Show description for a0b94ab
  boegel

  committed
  a0b94ab

• Merge branch 'develop' into feature/add-review-pr-option

  boegel

  committed
  ac13988