support use of %(startdir)s template in easyconfig files (WIP) #3160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 10, 2020
|
Small ping here. The change looks good as is to me and provides what is needed. The last 2 points are renaming start_dir to startdir in ECs, right? I'd suggest to just open an issue for that and leave that for later as it is'nt required for this, is it? |
|
@boegel should we move forward with this and handle startdir/start_dir later? |
|
the logs for the failing checks have expired.. |
|
@boegel conflict resolution needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
intends to fix #3158, but not finished (hence WIP)
TODO:
%(startdir)sis actually used in an easyconfig file)startdireasyconfig parameter (equivalent tostart_dir)start_direasyconfig parameter