significantly speed up -D/--dry-run by avoiding useless 'module show' #3203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
changed the title
|
Going in, thanks @boegel! |
|
@shahzebsiddiqui This should help quite a bit with |
|
thanks @boegel this will certainly help. I will upgrade and test it out once you release 4.1.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ModulesTool.existfalls back to usemodule showby default since the module names it is passed may be partial module names which won't show up inmodule avail.In
skip_availablewe're always passing full module names though, so there we can tell it the module names are not partial...This results in a speedup of about 2x for
eb -D!