-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for checksums specified in external checksums.json
file
#3749
add support for checksums specified in external checksums.json
file
#3749
Conversation
So far, I have assumed that one had either checksums in the EasyConfig file or a This is not really useful to reuse existing EasyConfigs with a bump I am rewriting the code such that both the checksums from the EasyConfig and the checksum from the Json file are loaded, and then providing a |
@boegel, do you think we need to address |
…s failing. removing it.
….json is picked up in test_checksum_step
….json, no need to hide it to make tests pass
@mboisson Some proposed cleanup for the test part of this in ComputeCanada#26 I intend to make a pass over the non-test part too to propose some minor improvements, but this looks really good overall, thanks for all the effort you've put into this already! 👍 |
generate test easyconfig without checksums to check whether checksums.json is picked up in test_checksum_step
tweaks + enhanced tests for checksums.json support
checksums.json
file
… in checksums.json
tweak test_inject_checksums_to_json to avoid relying on order of keys in checksums.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Renamed the branch since we switch from yaml to json.
This replaces #3748
to address
#3746
--inject-checksums
(added--inject-checksums-to-json
)I have tested this PR with
Python-3.8.2-GCCcore-9.3.0.eb
by removing the checksums from the EasyConfig, and with--enforce-checksums
enabled.It allows to remove checksums both for the main file and for the exts_list.