add support for %(start_dir)s easyconfig template #4073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Flamefire sorry for not looking at this sooner; mind fixing the conflict? |
This comment was marked as outdated.
This comment was marked as outdated.
For extensions we need to manually update the template values.
|
Going in, thanks @Flamefire! |
boegel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #4035 went stale with some issues remaining I tackled this. The test was quite tricky as this template can only be set once the source is extracted.
Hence I wrote the test so that it should be set in the configure and build step of a "regular" EasyConfig and in an extension which is where this will most likely be used.
The extension is very tricky:
start_dirin theoptionsduring__init__-> Move the relevant code down to theExtensionclass and clear the (new) template too@jfgrimm Please have a look here.